Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add maximum_refresh_time to run_tasks() #151

Merged
merged 3 commits into from
Jul 5, 2024
Merged

Add maximum_refresh_time to run_tasks() #151

merged 3 commits into from
Jul 5, 2024

Conversation

hagenw
Copy link
Member

@hagenw hagenw commented Jul 5, 2024

This is a follow up of #147, and adds the new maximum_refresh_time of audeer.progress_bar() to audeer.run_tasks() as well.

image

@hagenw hagenw marked this pull request as draft July 5, 2024 08:46
Copy link

codecov bot commented Jul 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.0%. Comparing base (187c3dc) to head (ed5bbc4).

Additional details and impacted files
Files Coverage Δ
audeer/core/utils.py 100.0% <100.0%> (ø)

@hagenw hagenw force-pushed the refresh-run-tasks branch from bbb892d to 8289079 Compare July 5, 2024 09:28
@hagenw hagenw marked this pull request as ready for review July 5, 2024 09:31
@hagenw hagenw requested a review from ChristianGeng July 5, 2024 09:32
Copy link
Member

@ChristianGeng ChristianGeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This MR makes the change in the the tqdm progress bar wrapper visible to the higher level function audeer.run_tasks. My main concerns had bin discussed in this precursor issue #147 .

Therefore approving can be done without further ado.

@hagenw hagenw merged commit c1c1c7e into main Jul 5, 2024
19 checks passed
@hagenw hagenw deleted the refresh-run-tasks branch July 5, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants